Skip to content

feat: allow embedded in-mem executor#1735

Open
arnaud-moncel wants to merge 2 commits into
mainfrom
feat/allow-in-mem-executor
Open

feat: allow embedded in-mem executor#1735
arnaud-moncel wants to merge 2 commits into
mainfrom
feat/allow-in-mem-executor

Conversation

@arnaud-moncel

@arnaud-moncel arnaud-moncel commented Jul 3, 2026

Copy link
Copy Markdown
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Add in-memory executor mode to EmbeddedWorkflowExecutor

  • Adds an inMemory flag to WorkflowExecutorEmbedOptions that builds the executor via buildInMemoryExecutor instead of a database-backed one, logging a warning about non-persistence.
  • Adds mutual exclusivity validation: passing both inMemory and database throws an error.
  • Removes fallback to DATABASE_URL and HTTP_PORT env vars; database is now required unless inMemory is true, and port defaults to 3400.
  • Risk: any callers relying on DATABASE_URL or HTTP_PORT env var fallbacks will now get an explicit error instead of silent fallback behavior.

Macroscope summarized eadeb28.

@qltysh

qltysh Bot commented Jul 3, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/agent/src/embedded-workflow-executor.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@PMerlet PMerlet changed the title feat: allow embeded in-mem executor feat: allow embedded in-mem executor Jul 3, 2026

@PMerlet PMerlet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants